Refactor RSpec/Focus, increase branch coverage #2033
Merged
+14
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Astute! And I imagine probably a sliver more performant. |
bquorning
force-pushed
the
focus-cop-coverage
branch
from
079992a to
4a9cbfe
Compare
pirj
reviewed
Feb 10, 2025
pirj
reviewed
Feb 10, 2025
bquorning
force-pushed
the
focus-cop-coverage
branch
from
4a9cbfe to
d181805
Compare
The corrector logic for pair_type/str_type/sym_type seems like a "generic" implementation, so I move things around to let that be a "default" case in the if/else block. Also, inlining `#focus_metadata` into `#on_send` means we don't even need to check the type. Co-authored-by: Phil Pirozhkov <[email protected]>
bquorning
force-pushed
the
focus-cop-coverage
branch
from
d181805 to
a78f6c7
Compare
bquorning
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The corrector logic for pair_type/str_type/sym_type seems like a "generic" implementation, so I move things around to let that be a "default" case in the if/else block.
To avoid conflicts with other PRs improving code coverage, the .simplecov file is not updated here.
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).