Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSpec/ExampleLength supports undocumented method_call as CountAsOne value #1728

Closed
kpalmvik opened this issue Sep 29, 2023 · 0 comments · Fixed by #1729
Closed

RSpec/ExampleLength supports undocumented method_call as CountAsOne value #1728

kpalmvik opened this issue Sep 29, 2023 · 0 comments · Fixed by #1729

Comments

@kpalmvik
Copy link

The documentation for RSpec/ExampleLength, implemented in example_length.rb, mentions three available values for CountAsOne

You can set literals you want to fold with CountAsOne. Available are: 'array', 'hash', and 'heredoc'.

But since the implementation shares code from Rspec CodeLength, it seems to be possible to use the undocumented method_call too.

The option method_call is documented in Metrics/MethodLength.
ydah added a commit that referenced this issue Oct 3, 2023
@ydah
Add documentation for RSpec/ExampleLength configuration option `Cou…
0529272 
…ntAsOne: [method_call]`

Fix: #1728
@ydah ydah mentioned this issue Oct 3, 2023
Merged
4 tasks
ydah added a commit that referenced this issue Oct 3, 2023
@ydah
Add documentation for RSpec/ExampleLength configuration option `Cou…
11e9bc6 
…ntAsOne: [method_call]`

Fix: #1728
@ydah ydah closed this as completed in #1729 Oct 4, 2023
ydah added a commit to rubocop/rubocop-rspec_rails that referenced this issue Mar 27, 2024
@ydah
Add documentation for RSpec/ExampleLength configuration option `Cou…
2d2e8a3 
…ntAsOne: [method_call]`

Fix: rubocop/rubocop-rspec#1728
ydah added a commit to rubocop/rubocop-rspec_rails that referenced this issue Mar 27, 2024
@ydah
Add documentation for RSpec/ExampleLength configuration option `Cou…
c05cd2b 
…ntAsOne: [method_call]`

Fix: rubocop/rubocop-rspec#1728
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@kpalmvik