Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#86] Fix an incorrect auto-correct for Rails/TimeZone #87

Merged

Conversation

koic
Copy link
Member

@koic koic commented Jul 12, 2019

Fixes #86.

This PR fixes an incorrect auto-correct for Rails/TimeZone when using Time.new.

Before

- Time.new
+ Time.zone.new  #=> NoMethodError: undefined method `new'

- Time.new(2019, 7, 7, 10, 15, 25)
+ Time.zone.new(2019, 7, 7, 10, 15, 25) #=> NoMethodError: undefined method `new'

After

- Time.new
+ Time.zone.now

- Time.new(2019, 7, 7, 10, 15, 25)
+ Time.zone.local(2019, 7, 7, 10, 15, 25)

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Fixes rubocop#86.

This PR fixes an incorrect auto-correct for `Rails/TimeZone` when using `Time.new`.

### Before

```diff
- Time.new
+ Time.zone.new  #=> NoMethodError: undefined method `new'

- Time.new(2019, 7, 7, 10, 15, 25)
+ Time.zone.new(2019, 7, 7, 10, 15, 25) #=> NoMethodError: undefined method `new'
```

### After

```diff
- Time.new
+ Time.zone.now

- Time.new(2019, 7, 7, 10, 15, 25)
+ Time.zone.local(2019, 7, 7, 10, 15, 25)
```
@koic koic force-pushed the fix_an_incorrect_auto_correct_for_time_zone branch from b919e57 to 94ad812 Compare July 12, 2019 04:59
@koic koic merged commit 9018ff2 into rubocop:master Jul 13, 2019
@koic koic deleted the fix_an_incorrect_auto_correct_for_time_zone branch July 13, 2019 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect auto-correction: Time.new -> Time.zone.new
1 participant