Remove unnecessary code to suppress warnings #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up rubocop#80. (Thank you for this PR that solved issue rubocop#79 early.) Rails cops has been removed from RuboCop 0.72. https://github.com/rubocop-hq/rubocop/releases/tag/v0.72.0 As a result of verification, the code to guard a warning is not necessary already.
koic
added a commit
to koic/rubocop-performance
that referenced
this pull request
Jun 30, 2019
Rails cops has been removed from RuboCop 0.72. https://github.com/rubocop-hq/rubocop/releases/tag/v0.72.0 As a result of verification, the code to guard a warning is not necessary already. Related PR ... rubocop/rubocop-rails#83
8 tasks
patrickm53
pushed a commit
to patrickm53/performance-develop-rubyonrails
that referenced
this pull request
Sep 23, 2022
Rails cops has been removed from RuboCop 0.72. https://github.com/rubocop-hq/rubocop/releases/tag/v0.72.0 As a result of verification, the code to guard a warning is not necessary already. Related PR ... rubocop/rubocop-rails#83
richardstewart0213
added a commit
to richardstewart0213/performance-build-Performance-optimization-analysis-
that referenced
this pull request
Nov 4, 2022
Rails cops has been removed from RuboCop 0.72. https://github.com/rubocop-hq/rubocop/releases/tag/v0.72.0 As a result of verification, the code to guard a warning is not necessary already. Related PR ... rubocop/rubocop-rails#83
Cute0110
added a commit
to Cute0110/Rubocop-Performance
that referenced
this pull request
Sep 28, 2023
Rails cops has been removed from RuboCop 0.72. https://github.com/rubocop-hq/rubocop/releases/tag/v0.72.0 As a result of verification, the code to guard a warning is not necessary already. Related PR ... rubocop/rubocop-rails#83
SerhiiMisiura
added a commit
to SerhiiMisiura/Rubocop-Performance
that referenced
this pull request
Oct 5, 2023
Rails cops has been removed from RuboCop 0.72. https://github.com/rubocop-hq/rubocop/releases/tag/v0.72.0 As a result of verification, the code to guard a warning is not necessary already. Related PR ... rubocop/rubocop-rails#83
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #80.
(Thank you for this PR that solved issue #79 early.)
Rails cops has been removed from RuboCop 0.72.
https://github.com/rubocop-hq/rubocop/releases/tag/v0.72.0
As a result of verification, the code to guard a warning is not necessary already.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.