Make Rails/CreateTableWithTimestamps
respect active_storage_variant_records
table
#570
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
Rails/CreateTableWithTimestamps
respectactive_storage_variant_records
table ofdb/migrate/*_create_active_storage_tables.active_storage.rb
auto-generated bybin/rails active_storage:install
even ifcreated_at
is not specified.It suppresses the following offense.
As far as I've heard from Rails committers,
active_storage_variant_records
table hasn't timestamp columns, probably as a result of discussions in the Rails community. If you want to consider the need, please discuss it with https://discuss.rubyonrails.org and give us feedback.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.and description in grammatically correct, complete sentences.
bundle exec rake default
. It executes all tests and RuboCop for itself, and generates the documentation.