Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #137] Make Rails/HasManyOrHasOneDependent aware of readonly is true #473

Conversation

koic
Copy link
Member

@koic koic commented May 1, 2021

Fixes #137.

This PR makes Rails/HasManyOrHasOneDependent aware of readonly? is true.

There may be false positives or false negatives with just def readonly? = true, but it makes it possible to detect perhaps general definition of readonly? method.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

…donly?` is `true`

Fixes rubocop#137.

This PR makes `Rails/HasManyOrHasOneDependent` aware of `readonly?` is `true`.

There may be false positives or false negatives with just `def readonly? = true`,
but it makes it possible to detect perhaps general definition of `readonly?` method.
@koic koic force-pushed the make_rails_has_many_or_has_one_dependent_aware_of_readonly_true branch from a14f012 to 6a415a8 Compare May 2, 2021 00:29
@koic koic merged commit adff619 into rubocop:master May 2, 2021
@koic koic deleted the make_rails_has_many_or_has_one_dependent_aware_of_readonly_true branch May 2, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails/HasManyOrHasOneDependent should not be an offence when the model is readonly
2 participants