Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false positive for Rails/DynamicFindBy #466

Merged

Conversation

koic
Copy link
Member

@koic koic commented Apr 26, 2021

Fixes rubocop/rubocop-jp#54 (Ja)

This PR fixes a false positive for Rails/DynamicFindBy when not inheriting ApplicationRecord and without no receiver.

A dynamic matcher without receiver is only possible if it inherits ApplicationRecord (ActiveRecord::Base).

For example, Capybara's find_by_id and Token's find_by_valid_token should be accepted by default.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Fixes rubocop/rubocop-jp#54 (Ja)

This PR fixes a false positive for `Rails/DynamicFindBy`
when not inheriting `ApplicationRecord` and without no receiver.

A dynamic matcher without receiver is only possible if it inherits
`ApplicationRecord` (`ActiveRecord::Base`).

For example, Capybara's `find_by_id` and Token's `find_by_valid_token`
should be accepted by default.

- https://www.rubydoc.info/github/jnicklas/capybara/Capybara/Node/Finders#find_by_id-instance_method
- https://github.com/fnando/tokens
@koic koic merged commit c63330e into rubocop:master Apr 27, 2021
@koic koic deleted the fix_false_positive_for_rails_dynamic_find_by branch April 27, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails/DynamicFindBy の誤検出
1 participant