Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #444] Mark Rails/Blank as unsafe auto-correction #445

Merged

Conversation

koic
Copy link
Member

@koic koic commented Mar 8, 2021

Fixes ##444.

This PR marks Rails/Blank as unsafe auto-correction because ' '.empty? returns false, but ' '.blank? returns true. Therefore, auto-correction is not compatible if the receiver is a non-empty blank string, tab, or newline meta characters.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Fixes #rubocop#444.

This PR marks `Rails/Blank` as unsafe auto-correction because `' '.empty?` returns false,
but `' '.blank?` returns true. Therefore, auto-correction is not compatible if the receiver
is a non-empty blank string, tab, or newline meta characters.
@koic koic force-pushed the mark_rails_blank_as_unsafe_auto_correction branch from 4121515 to 3a7fafc Compare March 8, 2021 02:57
@koic koic merged commit e9f4e69 into rubocop:master Mar 10, 2021
@koic koic deleted the mark_rails_blank_as_unsafe_auto_correction branch March 10, 2021 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants