Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #401] Fix an error for Rails/WhereEquals #405

Merged
merged 1 commit into from
Dec 12, 2020

Conversation

koic
Copy link
Member

@koic koic commented Dec 10, 2020

Fixes #401.

This PR fixes an error for Rails/WhereEquals when using only named placeholder template without replacement argument.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@koic koic force-pushed the fix_an_error_for_rails_where_equals branch from 7bfa1f6 to 4fa010a Compare December 10, 2020 09:37
Fixes rubocop#401.

This PR fixes an error for `Rails/WhereEquals` when
using only named placeholder template without replacement argument.
@koic koic force-pushed the fix_an_error_for_rails_where_equals branch from 4fa010a to 3eecd98 Compare December 12, 2020 16:50
@koic koic merged commit 97c8578 into rubocop:master Dec 12, 2020
@koic koic deleted the fix_an_error_for_rails_where_equals branch December 12, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails/WhereEquals throughs error with specific ActiveRecord usecase
1 participant