Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IgnoredMethods for Lint/NumberConversion #381

Merged
merged 1 commit into from
Feb 27, 2021

Conversation

dvandersluis
Copy link
Member

@dvandersluis dvandersluis commented Oct 28, 2020

Follows rubocop/rubocop#8950.

Adds Rails' duration methods to the IgnoredMethods list for Lint/NumberConversion, so that calling to_i on one of them does not register an offense.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@dvandersluis
Copy link
Member Author

/cc @koic

@koic
Copy link
Member

koic commented Nov 10, 2020

Thank you for opening the PR. This change requires RuboCop 1.1.0 or higher. I'll start reviewing after the next RuboCop Rails 2.9 release that is the last version to support RuboCop 0.x series (Before 1.0). Please wait a moment.

CHANGELOG.md Outdated Show resolved Hide resolved
@dvandersluis
Copy link
Member Author

@koic fixed your comments, sorry for the delay!

@koic koic merged commit 7a3f454 into rubocop:master Feb 27, 2021
@koic
Copy link
Member

koic commented Feb 27, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants