Add rack to runtime dependency
#36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference: https://github.com/rubocop-hq/rubocop/issues/5745 |
|
This looks useful to me.
This repository is WIP. I'm doing a hack like I think we can release after that hack (and prepare minimal document) . When releasing, I'd like report again to @toshimaru about repository name. |
|
Thank you for your merging and describing, @koic ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure the status of this repository. So if this pull request is not mergeable now, I think we keep open this pull request.
Rails/HttpStatuscop uses rack gem as an additional dependency to display more descriptive offense messages. The runtime dependencies do not include rack because RuboCop needs the gem only for the cop.I think we can add rack to runtime dependencies after separating
rubocop-railsgem.rubocopis used without rack sometimes, butrubocop-railsgem will be used with rails gem in most cases, so the environment includes rack already.If we add rack, installed gems does not increase.