[Fix #319] Fix a false positive for Rails/Inquiry
#321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugeneius
reviewed
Aug 8, 2020
| @@ -26,7 +26,11 @@ class Inquiry < Cop | |||
| MSG = "Prefer Ruby's comparison operators over Active Support's `inquiry`." | |||
|
|
|||
| def on_send(node) | |||
| add_offense(node, location: :selector) if node.method?(:inquiry) && node.arguments.empty? | |||
| return unless node.method?(:inquiry) && node.arguments.empty? | |||
| return unless (receiver = node.receiver) | |||
There was a problem hiding this comment.
How about adding a test that covers inquiry with no receiver, since that's what this line is for?
CHANGELOG.md
Outdated
| @@ -12,6 +12,7 @@ | |||
|
|
|||
| * [#315](https://github.com/rubocop-hq/rubocop-rails/pull/315): Allow to use frozen scope for `Rails/UniqueValidationWithoutIndex`. ([@krim][]) | |||
| * [#313](https://github.com/rubocop-hq/rubocop-rails/pull/313): Fix `Rails/ActiveRecordCallbacksOrder` to preserve the original callback execution order. ([@eugeneius][]) | |||
| * [#319](https://github.com/rubocop-hq/rubocop-rails/issues/319): Fix an false positive for `Rails/Inquiry` when `#inquiry`'s receiver is a variable. ([@koic][]) | |||
There was a problem hiding this comment.
Suggested change
| * [#319](https://github.com/rubocop-hq/rubocop-rails/issues/319): Fix an false positive for `Rails/Inquiry` when `#inquiry`'s receiver is a variable. ([@koic][]) | |
| * [#319](https://github.com/rubocop-hq/rubocop-rails/issues/319): Fix a false positive for `Rails/Inquiry` when `#inquiry`'s receiver is a variable. ([@koic][]) |
koic
force-pushed
the
fix_false_positive_for_rails_inquiry
branch
from
bcf9efe to
fbcda86
Compare
koic
changed the title
Rails/InquiryRails/Inquiry
Fixes rubocop#319. This PR fixes a false positive for `Rails/Inquiry` when `#inquiry`'s receiver is a variable. It should only detect when receiver is an array literal and a string literal.
koic
force-pushed
the
fix_false_positive_for_rails_inquiry
branch
from
fbcda86 to
a36dc5b
Compare
eugeneius
approved these changes
Aug 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #319.
This PR fixes a false positive for
Rails/Inquirywhen#inquiry's receiver is a variable.It should only detect when receiver is an array literal and a string literal.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.