Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autocorrect to Rails/RakeEnvironment cop #235

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Add autocorrect to Rails/RakeEnvironment cop #235

merged 1 commit into from
Apr 27, 2020

Conversation

tejasbubane
Copy link
Contributor

Closes #211

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

koic
koic reviewed Apr 20, 2020
View reviewed changes
config/default.yml Outdated Show resolved Hide resolved
@tejasbubane
Copy link
Contributor Author

@koic Fixed as per comments.

@tejasbubane tejasbubane requested a review from koic April 20, 2020 17:30
@tejasbubane
Copy link
Contributor Author

@koic changes done.

koic
koic reviewed Apr 27, 2020
View reviewed changes
lib/rubocop/cop/rails/rake_environment.rb Outdated
private

def corrected_task_dependency(task_name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to be named correct_task_dependency as a small point.

Suggested change
def corrected_task_dependency(task_name)
def correct_task_dependency(task_name)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@koic koic merged commit 8c2f945 into rubocop:master Apr 27, 2020
@koic
Copy link
Member

koic commented Apr 27, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koic koic koic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-correct for Rails/RakeEnvironment cop
2 participants
@tejasbubane @koic