Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #200] Make SchemaLoader aware of Rails 5 expression index #203

Conversation

pocke
Copy link
Contributor

@pocke pocke commented Feb 18, 2020

This pull request fixes #200

The error occurred on Rails 5 expression index.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic koic merged commit 652bb56 into rubocop:master Feb 20, 2020
@koic
Copy link
Member

koic commented Feb 20, 2020

Thanks!

@pocke pocke deleted the rails5-expression-index-for-UniqueValidationWithoutIndex-cop branch February 20, 2020 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The SchemaLoader raises an error on GitLab's schema.rb
2 participants