[Fix #184] Fix Rake/Environment to allow task with no block #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Jan 5, 2020
|
|
||
| it 'does not register an offense to task with no block' do | ||
| expect_no_offenses(<<~RUBY) | ||
| task(:spec).clear |
There was a problem hiding this comment.
This is a nitpick. do_something will be a more generic naming than clear.
There was a problem hiding this comment.
Thanks! I updated to task(:spec).clear to task(:foo).do_something
|
Can you add the change log entry? |
|
@koic I added the changelog entry. |
koic
reviewed
Jan 5, 2020
CHANGELOG.md
Outdated
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| ## master (unreleased) | |||
|
|
|||
| ### Bug fixes | |||
|
|
|||
| * [#184](https://github.com/rubocop-hq/rubocop-rails/issues/184): Fix Rake/Environment to allow task with no block. ([@hanachin][]) | |||
There was a problem hiding this comment.
Can you enclose the cop name in backticks?
-* [#184](https://github.com/rubocop-hq/rubocop-rails/issues/184): Fix Rake/Environment to allow task with no block. ([@hanachin][])
+* [#184](https://github.com/rubocop-hq/rubocop-rails/issues/184): Fix `Rake/Environment` to allow task with no block. ([@hanachin][])
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #184 .
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.