FIX #159 enum hash auto correct for % arrays #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocke
reviewed
Dec 3, 2019
lib/rubocop/cop/rails/enum_hash.rb
Outdated
| def source(elem) | ||
| case elem.type | ||
| when :str | ||
| "\"#{elem.value}\"" |
There was a problem hiding this comment.
I guess String#dump is better than the string interpolation. String#dump returns eval-safe string.
Can you replace it?
There was a problem hiding this comment.
Of course ! Than you for this I tried to find a way to do so !
There was a problem hiding this comment.
It seems like the Symbol#inspect do exactly the same ! Replaced 👍
koic
reviewed
Dec 3, 2019
|
This looks good to me. Could you squash your commits into one? |
|
👍 My bad, though it was during the merge / squash. |
ngouy
force-pushed
the
FIX-enum-hash-auto-correct-for-percent-literals
branch
from
80857ed to
4d79291
Compare
koic
approved these changes
Dec 3, 2019
pocke
approved these changes
Dec 3, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update code and tests so autocorrect for enum hash handle % array notations such as
%w[done todo archived]are well corrected