Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress an offense for rails/presence_spec.rb #143

Merged

Conversation

koic
Copy link
Member

@koic koic commented Oct 21, 2019

This PR suppresses the following offense for rails/presence_spec.rb.

% bundle exec rake
(snip)

Offenses:

spec/rubocop/cop/rails/presence_spec.rb:70:66: W:
Lint/UnneededCopDisableDirective: Unnecessary disabling of
Metrics/LineLength.
  it_behaves_like 'offense', <<~RUBY.chomp, <<~FIXED.chomp, 1, 7
  # rubocop:disable Metrics/LineLength
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

126 files inspected, 1 offense detected
RuboCop failed!

https://circleci.com/gh/rubocop-hq/rubocop-rails/1721


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

This PR suppresses the following offense for rails/presence_spec.rb.

```console
% bundle exec rake
(snip)

Offenses:

spec/rubocop/cop/rails/presence_spec.rb:70:66: W:
Lint/UnneededCopDisableDirective: Unnecessary disabling of
Metrics/LineLength.
  it_behaves_like 'offense', <<~RUBY.chomp, <<~FIXED.chomp, 1, 7
  # rubocop:disable Metrics/LineLength
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

126 files inspected, 1 offense detected
RuboCop failed!
```

https://circleci.com/gh/rubocop-hq/rubocop-rails/1721
@koic koic merged commit 6bb2e9f into rubocop:master Oct 21, 2019
@koic koic deleted the suppress_an_offenses_for_rails_presence_spec branch October 21, 2019 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant