[Fix #120] Fix save-in-conditional checking in `Rails/SaveBang` #121

jas14 · 2019-08-28T15:50:02Z

Fixes #120.

The Rails/SaveBang rule emitted incorrect errors about using the return value of save-like calls in conditional nodes. It did not differentiate between such calls in the body versus the condition, where only the latter is necessarily a boolean expression.

Before submitting the PR make sure the following are checked:

Wrote good commit messages.
Commit message starts with [Fix #issue-number] (if the related issue exists).
Feature branch is up-to-date with master (if not - rebase it).
Squashed related commits together.
Added tests.
Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

jas14 · 2019-09-03T19:44:39Z

ping

CHANGELOG.md

lib/rubocop/cop/rails/save_bang.rb

CHANGELOG.md

lib/rubocop/cop/rails/save_bang.rb

jas14

Thanks for the continued reviews @koic !

Fixes rubocop#120. The Rails/SaveBang rule emitted incorrect errors about using the return value of save-like calls in conditional nodes. It did not differentiate between such calls in the body versus the condition, where only the latter is necessarily a boolean expression.

koic · 2019-09-17T00:43:10Z

Thanks!

jas14 force-pushed the fix-savebang-in-conditional branch from f4f1573 to c5bb3fb Compare September 11, 2019 17:41