Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create_or_find_by to save_bang.rb #102

Merged
merged 2 commits into from
Aug 9, 2019
Merged

Conversation

MaximeLaurenty
Copy link
Contributor

create_or_find_by will be implemented in Rails 6.0 (rails/rails#31989)
However we've decided to use it before it comes out, and would love it to be in rubocop scope as well.
I guess we're not the first ones to do it, so it could benefit to most.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic
Copy link
Member

koic commented Aug 8, 2019

CI has failed, so please correct it.
https://circleci.com/gh/rubocop-hq/rubocop-rails/1216

And please add an entry to CHANGELOG.md.

CHANGELOG.md Outdated Show resolved Hide resolved
@MaximeLaurenty MaximeLaurenty force-pushed the patch-1 branch 3 times, most recently from 2279600 to 8665d4e Compare August 8, 2019 17:27
@koic koic merged commit 3902899 into rubocop:master Aug 9, 2019
@koic
Copy link
Member

koic commented Aug 9, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants