False Rails/HasManyOrHasOneDependent warning

[leopirolo]

Hello,

Not sure if I'm doing this right or not, but I'm having some issues with has_many associations.

Example

Here's an example:

class Character < ::ApplicationRecord
  has_many(:items, **{ dependent: :destroy })
end

Actual behaviour

Here's the warning message I get:

Specify a `:dependent` option. (convention:Rails/HasManyOrHasOneDependent)

But if I write this line like this, without keywords brackets, I get no warning:

class Character < ::ApplicationRecord
  has_many(:items, dependent: :destroy)
end

Expected behaviour

No warning messages?

Specs

• Ruby 3.0.2
• Rails 6.1.4.1
• Rubocop 1.20.0

[andyw8]

There are no warnings when it's written as:

has_many(:items, { dependent: :destroy })

I don't think there's any reason to use the double splat (**) here.

[koic]

This is affected by changes in the keyword arguments in Ruby 3.0.
https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/

One of the following changes is required:

has_many(:items, dependent: :destroy) # I strongly recommend this.
has_many(:items, **{dependent: :destroy})

I've opened #530, the latter will be accepted, but I strongly recommend the former (It's simple and clear) .

[erickm32]

Hi @koic, I have a situation that I believe it could fit on this issue, but I'm on ruby 2.7 yet.
We have a class that has several has_many relations and they share some options like this

class MyClass < ApplicationRecord

  DEFAULT_OPERATIONABLE_OPTIONS = { source: :operationable, dependent: :restrict_with_error }.freeze

  has_many :items, DEFAULT_OPERATIONABLE_OPTIONS.merge(source_type: 'Item', through: :some_column)
  has_many :things,  DEFAULT_OPERATIONABLE_OPTIONS.merge(source_type: 'Thing',  through: :some_column)
  ...

  has_many :other_items, DEFAULT_OPERATIONABLE_OPTIONS.merge(source_type: 'OtherItem', through: :some_other_column)
  has_many :other_things, DEFAULT_OPERATIONABLE_OPTIONS.merge(source_type: 'OtherThing', through: :some_other_column)
  ...
end

I'm getting the same error when running rubocop, could this be a bug or this is not acceptable?

I'm running on rubocop 1.25.1 (rubocop-rails 2.13.2), Rails 6.1.4.6 and ruby 2.7.2p137 [x86_64-linux], on the process of upgrading from rails 5.2.