Rails/HasManyOrHasOneDependent should allow combination of association extension and with_options

[ohbarye]

Rails/HasManyOrHasOneDependent should allow combination of association extension and with_options.

As for association extensions, please see the official document.

---

Expected behavior

The following code does not offense Rails/HasManyOrHasOneDependent cop rule since it actually gives dependent option.

class Person < ApplicationRecord
  with_options dependent: :destroy do
    has_many :foo do
      def bar
      end
    end
  end
end

Actual behavior

rubocop-rails treats the code as offensed.

        class Person < ApplicationRecord
          with_options dependent: :destroy do
            has_many :foo do
       +    ^^^^^^^^ Specify a `:dependent` option.
              def bar
              end
            end

Steps to reproduce the problem

1. git clone https://github.com/rubocop-hq/rubocop-rails.git && cd rubocop-rails && bundle install
2. Save the following patch as patch.diff

diff --git a/spec/rubocop/cop/rails/has_many_or_has_one_dependent_spec.rb b/spec/rubocop/cop/rails/has_many_or_has_one_dependent_spec.rb
index 2d9ab5e60..a99b4a9a9 100644
--- a/spec/rubocop/cop/rails/has_many_or_has_one_dependent_spec.rb
+++ b/spec/rubocop/cop/rails/has_many_or_has_one_dependent_spec.rb
@@ -132,6 +132,19 @@ RSpec.describe RuboCop::Cop::Rails::HasManyOrHasOneDependent do
         RUBY
       end
 
+      it "doesn't register an offense for `with_options dependent: :destroy` and for using association extension" do
+        expect_no_offenses(<<~RUBY)
+          class Person < ApplicationRecord
+            with_options dependent: :destroy do
+              has_many :foo do
+                def bar
+                end
+              end
+            end
+          end
+        RUBY
+      end
+
       context 'Multiple associations' do
         it "doesn't register an offense for " \
            '`with_options dependent: :destroy`' do

3. git apply patch.diff
4. bundle exec rspec spec/rubocop/cop/rails/has_many_or_has_one_dependent_spec.rb:135

RuboCop version

$ [bundle exec] rubocop -V
1.7.0 (using Parser 3.0.0.0, rubocop-ast 1.4.0, running on ruby 2.7.1 x86_64-darwin19)