-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails/HasManyOrHasOneDependent should accept dependent: nil
#147
Comments
Hmm, is this option missing from the docs? https://api.rubyonrails.org/classes/ActiveRecord/Associations/ClassMethods.html#method-i-has_many |
… On Sun, Nov 3, 2019 at 3:43 PM Andy Waite ***@***.***> wrote:
Hmm, is this option missing from the docs?
https://api.rubyonrails.org/classes/ActiveRecord/Associations/ClassMethods.html#method-i-has_many
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#147>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACYZ5TM732NHT76DE6LFLQR5H2PANCNFSM4JIM6LWA>
.
|
Thanks. I think it's probably best to wait for a response from someone on the Rails team before this is added to rubocop-rails. |
merged into rails now ... good to go here ? |
👍 PR welcome. |
koic
added a commit
to koic/rubocop-rails
that referenced
this issue
Apr 27, 2021
…ndent` Fixes rubocop#147. Closes rubocop#176. This PR fixes a false positive for `Rails/HasManyOrHasOneDependent` when specifying defalt `dependent: nil` strategy.
koic
added a commit
to koic/rubocop-rails
that referenced
this issue
Apr 27, 2021
…ndent` Fixes rubocop#147. Closes rubocop#176. This PR fixes a false positive for `Rails/HasManyOrHasOneDependent` when specifying default `dependent: nil` strategy.
9 tasks
koic
added a commit
that referenced
this issue
Apr 27, 2021
…ny_or_has_one_dependent [Fix #147] Fix a false positive for `Rails/HasManyOrHasOneDependent`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We use
dependent: nil
to mean "I though about dependencies and nothing should be done"it's also a valid option in rails ... so please don't alert on this.
The text was updated successfully, but these errors were encountered: