[Fix #725] Fix an incorrect autocorrect for Rails/DotSeparatedKeys

Fixes #725. This PR fixes an incorrect autocorrect for `Rails/DotSeparatedKeys` when a key starts with dot.
rubocop · Jun 21, 2022 · d085218 · d085218
1 parent b671caa
commit d085218
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/changelog/fix_an_incorrect_autocorrect_for_rails_dot_separated_keys.md b/changelog/fix_an_incorrect_autocorrect_for_rails_dot_separated_keys.md
@@ -0,0 +1 @@
+* [#725](https://github.com/rubocop/rubocop-rails/issues/725): Fix an incorrect autocorrect for `Rails/DotSeparatedKeys` when a key starts with dot. ([@koic][])
diff --git a/lib/rubocop/cop/rails/dot_separated_keys.rb b/lib/rubocop/cop/rails/dot_separated_keys.rb
@@ -53,7 +53,7 @@ def should_convert_scope?(scope_node)
         end
 
         def new_key(key_node, scope_node)
-          "'#{scopes(scope_node).map(&:value).join('.')}.#{key_node.value}'"
+          "'#{scopes(scope_node).map(&:value).join('.')}.#{key_node.value}'".squeeze('.')
         end
 
         def scopes(scope_node)

diff --git a/spec/rubocop/cop/rails/dot_separated_keys_spec.rb b/spec/rubocop/cop/rails/dot_separated_keys_spec.rb
@@ -19,6 +19,8 @@
                     ^^^^^^^^^^^^^^^^^^^ Use the dot-separated keys instead of specifying the `:scope` option.
       I18n.t :key, scope: :one
                    ^^^^^^^^^^^ Use the dot-separated keys instead of specifying the `:scope` option.
+      I18n.t '.key', scope: :one
+                     ^^^^^^^^^^^ Use the dot-separated keys instead of specifying the `:scope` option.
     RUBY
 
     expect_correction(<<~RUBY)
@@ -30,6 +32,7 @@
       I18n.t 'one.two.key'
       I18n.t 'one.two.key'
       I18n.t 'one.key'
+      I18n.t 'one.key'
     RUBY
   end
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		* [#725](https://github.com/rubocop/rubocop-rails/issues/725): Fix an incorrect autocorrect for `Rails/DotSeparatedKeys` when a key starts with dot. ([@koic][])