Merge pull request #194 from koic/fix_a_false_positive_for_http_posit…

…ional_arguments [Fix #180] Fix a false positive for `HttpPositionalArguments`
rubocop · Feb 2, 2020 · 511ebea · 511ebea
2 parents afbd115 + f24fae8
commit 511ebea
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## master (unreleased)
 
+### Bug fixes
+
+* [#180](https://github.com/rubocop-hq/rubocop-rails/issues/180): Fix a false positive for `HttpPositionalArguments` when using `get` method with `:to` option. ([@koic][])
+
 ## 2.4.2 (2020-01-26)
 
 ### Bug fixes

diff --git a/lib/rubocop/cop/rails/http_positional_arguments.rb b/lib/rubocop/cop/rails/http_positional_arguments.rb
@@ -22,7 +22,7 @@ class HttpPositionalArguments < Cop
         MSG = 'Use keyword arguments instead of ' \
               'positional arguments for http call: `%<verb>s`.'
         KEYWORD_ARGS = %i[
-          method params session body flash xhr as headers env
+          method params session body flash xhr as headers env to
         ].freeze
         HTTP_METHODS = %i[get post put patch delete head].freeze
 

diff --git a/spec/rubocop/cop/rails/http_positional_arguments_spec.rb b/spec/rubocop/cop/rails/http_positional_arguments_spec.rb
@@ -113,6 +113,12 @@
       RUBY
     end
 
+    it 'registers an offense for get method with `:to` option' do
+      expect_no_offenses(<<~RUBY)
+        get '/test', to: 'admin/admin#test'
+      RUBY
+    end
+
     it 'registers an offense for post method' do
       expect_offense(<<~RUBY)
         post :create, user_id: @user.id