Merge pull request #198 from koic/update_testing_context

Update testing context for Rails versions

spec/rubocop/cop/rails/application_job_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 RSpec.describe RuboCop::Cop::Rails::ApplicationJob do
-  context 'rails 4', :rails4, :config do
+  context 'Rails 4.2', :rails42, :config do
     subject(:cop) { described_class.new(config) }
 
     it 'allows ApplicationJob to be defined' do
@@ -55,7 +55,7 @@ class Nested::MyJob < ActiveJob::Base
     end
   end
 
-  context 'rails 5', :rails5 do
+  context 'Rails 5.0', :rails50 do
     subject(:cop) { described_class.new }
 
     it 'allows `ApplicationJob` to be defined' do

spec/rubocop/cop/rails/application_mailer_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 RSpec.describe RuboCop::Cop::Rails::ApplicationMailer do
-  context 'rails 4', :rails4, :config do
+  context 'Rails 4.2', :rails42, :config do
     subject(:cop) { described_class.new(config) }
 
     it 'allows `ApplicationMailer` to be defined' do
@@ -55,7 +55,7 @@ class Nested::MyMailer < ActionMailer::Base; end
     end
   end
 
-  context 'rails 5', :rails5 do
+  context 'Rails 5.0', :rails50 do
     subject(:cop) { described_class.new }
 
     it 'allows `ApplicationMailer` to be defined' do

spec/rubocop/cop/rails/application_record_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 RSpec.describe RuboCop::Cop::Rails::ApplicationRecord do
-  context 'rails 4', :rails4, :config do
+  context 'Rails 4.2', :rails42, :config do
     subject(:cop) { described_class.new(config) }
 
     it 'allows ApplicationRecord to be defined' do
@@ -51,7 +51,7 @@ class Nested::MyModel < ActiveRecord::Base; end
     end
   end
 
-  context 'rails 5', :rails5 do
+  context 'Rails 5.0', :rails50 do
     subject(:cop) { described_class.new }
 
     it 'allows ApplicationRecord to be defined' do

spec/rubocop/cop/rails/bulk_change_table_spec.rb

@@ -399,17 +399,13 @@ def change
       }
     end
 
-    context 'with Rails 5.2' do
-      let(:rails_version) { 5.2 }
-
+    context 'with Rails 5.2', :rails52 do
       it_behaves_like 'offense'
       it_behaves_like 'no offense for mysql'
       it_behaves_like 'offense for postgresql'
     end
 
-    context 'with Rails 5.1' do
-      let(:rails_version) { 5.1 }
-
+    context 'with Rails 5.1', :rails51 do
       it_behaves_like 'no offense'
       it_behaves_like 'no offense for mysql'
       it_behaves_like 'no offense for postgresql'
@@ -449,15 +445,11 @@ def change
         }
       end
 
-      context 'with Rails 5.2' do
-        let(:rails_version) { 5.2 }
-
+      context 'with Rails 5.2', :rails52 do
         it_behaves_like 'offense for postgresql'
       end
 
-      context 'with Rails 5.1' do
-        let(:rails_version) { 5.1 }
-
+      context 'with Rails 5.1', :rails51 do
         it_behaves_like 'no offense for postgresql'
       end
     end

spec/rubocop/cop/rails/http_positional_arguments_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 RSpec.describe RuboCop::Cop::Rails::HttpPositionalArguments do
-  context 'rails 4', :rails4, :config do
+  context 'Rails 4.2', :rails42, :config do
     subject(:cop) { described_class.new(config) }
 
     it 'does not register an offense for get method' do
@@ -99,7 +99,7 @@
     end
   end
 
-  context 'rails 5 and above', :rails5 do
+  context 'Rails 5.0 and above', :rails50 do
     subject(:cop) { described_class.new }
 
     it 'registers an offense for get method' do

spec/rubocop/cop/rails/inverse_of_spec.rb

@@ -1,10 +1,8 @@
 # frozen_string_literal: true
 
-RSpec.describe RuboCop::Cop::Rails::InverseOf do
+RSpec.describe RuboCop::Cop::Rails::InverseOf, :config do
   subject(:cop) { described_class.new(config) }
 
-  let(:config) { RuboCop::Config.new }
-
   context 'with scope' do
     it 'registers an offense when not specifying `:inverse_of`' do
       expect_offense(<<~RUBY)
@@ -90,7 +88,7 @@ class Person
   end
 
   context '`:as` option' do
-    context 'Rails < 5.2', :rails5 do
+    context 'Rails <= 5.1', :rails51 do
       it 'registers an offense when not specifying `:inverse_of`' do
         expect_offense(<<~RUBY)
           class Person
@@ -101,9 +99,7 @@ class Person
       end
     end
 
-    context 'Rails >= 5.2', :config do
-      let(:rails_version) { 5.2 }
-
+    context 'Rails >= 5.2', :rails52 do
       it 'does not register an offense when not specifying `:inverse_of`' do
         expect_no_offenses(
           'has_many :pictures, as: :imageable'

spec/rubocop/cop/rails/redundant_receiver_in_with_options_spec.rb

@@ -3,9 +3,7 @@
 RSpec.describe RuboCop::Cop::Rails::RedundantReceiverInWithOptions, :config do
   subject(:cop) { described_class.new(config) }
 
-  context 'rails >= 4.2' do
-    let(:rails_version) { 4.2 }
-
+  context 'Rails >= 4.2', :rails42 do
     it 'registers an offense and corrects using explicit receiver ' \
       'in `with_options`' do
       expect_offense(<<~RUBY)
@@ -96,9 +94,7 @@ class Account < ApplicationRecord
     end
   end
 
-  context 'rails <= 4.1' do
-    let(:rails_version) { 4.1 }
-
+  context 'Rails <= 4.1', :rails41 do
     it 'does not register an offense when using explicit receiver in ' \
        '`with_options`' do
       expect_no_offenses(<<~RUBY)

spec/support/shared_contexts.rb

@@ -1,9 +1,29 @@
 # frozen_string_literal: true
 
-RSpec.shared_context 'with Rails 4', :rails4 do
+RSpec.shared_context 'with Rails 4.0', :rails40 do
   let(:rails_version) { 4.0 }
 end
 
-RSpec.shared_context 'with Rails 5', :rails5 do
+RSpec.shared_context 'with Rails 4.1', :rails41 do
+  let(:rails_version) { 4.1 }
+end
+
+RSpec.shared_context 'with Rails 4.2', :rails42 do
+  let(:rails_version) { 4.2 }
+end
+
+RSpec.shared_context 'with Rails 5.0', :rails50 do
   let(:rails_version) { 5.0 }
 end
+
+RSpec.shared_context 'with Rails 5.1', :rails51 do
+  let(:rails_version) { 5.1 }
+end
+
+RSpec.shared_context 'with Rails 5.2', :rails52 do
+  let(:rails_version) { 5.2 }
+end
+
+RSpec.shared_context 'with Rails 6.0', :rails60 do
+  let(:rails_version) { 6.0 }
+end