Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back Antora to ~ version #9

Merged
merged 1 commit into from
Dec 29, 2022
Merged

Conversation

pirj
Copy link
Member

@pirj pirj commented Dec 29, 2022

Following this checklist


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with main (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • [-] Updated documentation.
  • [-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@pirj pirj self-assigned this Dec 29, 2022
@pirj pirj requested review from bquorning and ydah December 29, 2022 18:59
@pirj
Copy link
Member Author

pirj commented Dec 29, 2022

I couldn't push directly to main 🤷

Enumerating objects: 7, done.
Counting objects: 100% (7/7), done.
Delta compression using up to 4 threads
Compressing objects: 100% (4/4), done.
Writing objects: 100% (4/4), 389 bytes | 194.00 KiB/s, done.
Total 4 (delta 2), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (2/2), completed with 2 local objects.
remote: error: GH006: Protected branch update failed for refs/heads/main.
remote: error: 10 of 10 required status checks are expected.
To github.com:rubocop/rubocop-capybara.git
 ! [remote rejected] main -> main (protected branch hook declined)
error: failed to push some refs to 'github.com:rubocop/rubocop-capybara.git'

I have no idea what 10/10 required status checks it tells about.

@pirj pirj merged commit 10e2d89 into main Dec 29, 2022
@pirj pirj deleted the antora-docs-post-release-revert branch December 29, 2022 19:01
@bquorning
Copy link
Contributor

I have no idea what 10/10 required status checks it tells about.

That would be these 10:

image

@bquorning
Copy link
Contributor

Do you want to be able to push directly to main?

@pirj
Copy link
Member Author

pirj commented Dec 29, 2022

Not really, I'm fine with such small PRs, let's keep main protected from sudden mistaken pushes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants