Fix a false positive for Rails/ReversibleMigration

[sinsoku]

The change_table method is reversible when using change_default with the :from and :to options.
However, RuboCop detects Rails/ReversibleMigration incorrectly, so it fixes.

---

Before submitting the PR make sure the following are checked:

• Wrote good commit messages.
• Commit message starts with [Fix #issue-number] (if the related issue exists).
• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
• The PR relates to only one subject with a clear title
  and description in grammatically correct, complete sentences.
• Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

[koic]

It would be better to replace IRREVERSIBLE_CHANGE_TABLE_CALLS constant with the following method.

diff --git a/lib/rubocop/cop/rails/reversible_migration.rb b/lib/rubocop/cop/rails/reversible_migration.rb
index 782b151fd..bf0179c57 100644
--- a/lib/rubocop/cop/rails/reversible_migration.rb
+++ b/lib/rubocop/cop/rails/reversible_migration.rb
@@ -127,9 +127,6 @@ module RuboCop
       # @see https://api.rubyonrails.org/classes/ActiveRecord/Migration/CommandRecorder.html
       class ReversibleMigration < Cop
         MSG = '%<action>s is not reversible.'
-        IRREVERSIBLE_CHANGE_TABLE_CALLS = %i[
-          change remove
-        ].freeze

         def_node_matcher :irreversible_schema_statement_call, <<-PATTERN
           (send nil? ${:change_table_comment :execute :remove_belongs_to} ...)
@@ -244,8 +241,7 @@ module RuboCop
         def check_change_table_offense(receiver, node)
           method_name = node.method_name
           return if receiver != node.receiver &&
-                    !IRREVERSIBLE_CHANGE_TABLE_CALLS.include?(method_name) &&
-                    !irreversible_change_default?(node)
+                    reversible_change_table_call?(node)

           add_offense(
             node,
@@ -253,9 +249,15 @@ module RuboCop
           )
         end
-        def irreversible_change_default?(node)
-          node.method_name == :change_default &&
-            !all_hash_key?(node.arguments.last, :from, :to)
+        def reversible_change_table_call?(node)
+          case node.method_name
+          when :change, :remove
+            false
+          when :change_default
+            all_hash_key?(node.arguments.last, :from, :to)
+          else
+            true
+          end
         end

         def within_change_method?(node)

[sinsoku]

I updated. Thank you for your review. ❤️

[koic]

Thanks!