Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s2s requests now firing BID_REQUESTED event #11

Merged
merged 1 commit into from
Nov 22, 2017
Merged

s2s requests now firing BID_REQUESTED event #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/adaptermanager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,11 @@ exports.callBids = (adUnits, bidRequests, addBidResponse, doneCb) => {
return allBidders.includes(adapter);
}).join(',')}`);

// fire BID_REQUESTED event for each s2s bidRequest
serverBidRequests.forEach(bidRequest => {
events.emit(CONSTANTS.EVENTS.BID_REQUESTED, bidRequest);
});

// make bid requests
s2sAdapter.callBids(
s2sBidRequest,
Expand Down
51 changes: 51 additions & 0 deletions test/spec/unit/core/adapterManager_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { config } from 'src/config';
import { registerBidder } from 'src/adapters/bidderFactory';
import { setSizeConfig } from 'src/sizeMapping';
var s2sTesting = require('../../../../modules/s2sTesting');
var events = require('../../../../src/events');

const CONFIG = {
enabled: true,
Expand Down Expand Up @@ -90,6 +91,22 @@ describe('adapterManager tests', () => {

sinon.assert.called(utils.logError);
});

it('should emit BID_REQUESTED event', () => {
// function to count BID_REQUESTED events
let cnt = 0;
let count = () => cnt++;
events.on(CONSTANTS.EVENTS.BID_REQUESTED, count);
AdapterManager.bidderRegistry['appnexus'] = appnexusAdapterMock;
let adUnits = getAdUnits();
let bidRequests = AdapterManager.makeBidRequests(adUnits, 1111, 2222, 1000);
AdapterManager.callBids(adUnits, bidRequests, () => {}, () => {});
expect(cnt).to.equal(1);
sinon.assert.calledOnce(appnexusAdapterMock.callBids);
appnexusAdapterMock.callBids.reset();
delete AdapterManager.bidderRegistry['appnexus'];
events.off(CONSTANTS.EVENTS.BID_REQUESTED, count);
});
});

describe('S2S tests', () => {
Expand Down Expand Up @@ -253,6 +270,40 @@ describe('adapterManager tests', () => {
expect(requestObj.ad_units.length).to.equal(2);
sinon.assert.calledOnce(prebidServerAdapterMock.callBids);
});

describe('BID_REQUESTED event', () => {
// function to count BID_REQUESTED events
let cnt, count = () => cnt++;

beforeEach(() => {
cnt = 0;
events.on(CONSTANTS.EVENTS.BID_REQUESTED, count);
});

afterEach(() => {
events.off(CONSTANTS.EVENTS.BID_REQUESTED, count);
});

it('should fire for s2s requests', () => {
let adUnits = getAdUnits();
let bidRequests = AdapterManager.makeBidRequests(adUnits, 1111, 2222, 1000);
AdapterManager.callBids(adUnits, bidRequests, () => {}, () => {});
expect(cnt).to.equal(1);
sinon.assert.calledOnce(prebidServerAdapterMock.callBids);
});

it('should fire for simultaneous s2s and client requests', () => {
AdapterManager.bidderRegistry['adequant'] = adequantAdapterMock;
let adUnits = getAdUnits();
let bidRequests = AdapterManager.makeBidRequests(adUnits, 1111, 2222, 1000);
AdapterManager.callBids(adUnits, bidRequests, () => {}, () => {});
expect(cnt).to.equal(2);
sinon.assert.calledOnce(prebidServerAdapterMock.callBids);
sinon.assert.calledOnce(adequantAdapterMock.callBids);
adequantAdapterMock.callBids.reset();
delete AdapterManager.bidderRegistry['adequant'];
});
});
}); // end s2s tests

describe('s2sTesting', () => {
Expand Down