Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed first and last item snap behavior #7

Closed
wants to merge 1 commit into from

Conversation

shihochan
Copy link

I was going to fix first and last item snap behavior.

Now, the last item of Gravity.START and Gravity.TOP can't show completely.
Below is the screen shot:

And the first item of Gravity.END and GRAVITY.BOTTOM have a same issue.
I was going to fix it.

@rubensousa
Copy link
Owner

Can you make this behavior optional by adding a setter method? I prefer the default behavior, that's why I didn't had this initially.

@shihochan
Copy link
Author

@rubensousa
Thank you for your reply. You are right.

Can you make this behavior optional by adding a setter method?

I will fix it!

@Zanexess
Copy link

Zanexess commented Sep 21, 2016

I found the issue with android:clipToPadding="false" in this solution.
For example we have outer vertical RecyclerView and some horizontal recyclers inside of it.
Left and right padding of every inner recyclerView for example 10dp.
We save the position of every inner recycler, while scrolling. When we back, clip to padding affects wrong.
Any ideas, how to fix it?

rubensousa added a commit that referenced this pull request Sep 24, 2016
@rubensousa
Copy link
Owner

@Zanexess, this sample also uses clipToPadding=false and the behavior seems fine. I'm going to release 0.2 soon, so I suggest you to try it. If there's something wrong, just create an issue.
Closing this as it'll be added in 0.2

@rubensousa rubensousa closed this Sep 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants