Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring gapi.auth2.ClientConfig #11

Closed
bxboxer219 opened this issue Jul 28, 2017 · 6 comments
Closed

Configuring gapi.auth2.ClientConfig #11

bxboxer219 opened this issue Jul 28, 2017 · 6 comments

Comments

@bxboxer219
Copy link

Hi Ruben(@rubenCodeforges),

First off, thanks for all of your work on this package.

I'm working on an app that is based on your reporting example.

Currently, the app works well, and I am able to sign in the user with their Google account. However, I would like for the oAuth dialog box to be redirected to (at Sign In), instead of popping up in a new tab.

I noticed that in the JS client library, Google mentions the gapi.auth2.ClientConfig interface for configuring parameters for gapi.auth2.init. Inside of this interface, I noticed ux_mode allows you to set the dialog box to either popup or redirect mode.

I tried adding ux_mode and redirect_uri settings into different parts of the app, but wasn't quite sure where to add these settings in, with regards to ng-gapi. Do you know if gapi.auth2.ClientConfig is able to be configured with ng-gapi, so that on sign in, the user is redirected to the oauth dialog box?

Any help is greatly appreciated.

Thanks for your time.

Sincerely,

Blaine H.

@rubenCodeforges
Copy link
Owner

rubenCodeforges commented Jul 29, 2017 via email

@rubenCodeforges
Copy link
Owner

@bxboxer219 i will add a new config param for that , it will take perhaps 1d - 2d as im occupied with work

rubenCodeforges added a commit that referenced this issue Jul 30, 2017
- reflected the gapi clientConfig
- Readme updated
- example updated
@rubenCodeforges
Copy link
Owner

rubenCodeforges commented Jul 30, 2017

@bxboxer219 the npm package is updated with new changes , pease remove old version from node_modules and do a fresh install. new version is [email protected].

In that version you can provide all parameters in the forRoot() method.
See the interface ClientConfig.
Also pleas report back if it worked out for you and if it did please star ;)

@bxboxer219
Copy link
Author

Thanks Ruben! I'm out at lunch right now but will update my project whenever I get home.

I've starred the project, and will be sure to update this thread after I adjust my code.

Thanks for everything :)

@bxboxer219
Copy link
Author

I updated ng-gapi and the gapiClientConfig, and everything is working perfectly.

Thanks again for being so responsive, and for adding this enhancement so quick @rubenCodeforges

@rubenCodeforges
Copy link
Owner

@bxboxer219 you are welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants