Small fixes for npm

rubenCodeforges · May 6, 2017 · 07a54e2 · 07a54e2
1 parent ce54538
commit 07a54e2
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 24 deletions.
diff --git a/package.json b/package.json
@@ -1,9 +1,9 @@
 {
   "name": "ng-gapi",
-  "version": "0.0.36",
+  "version": "0.0.39",
   "description": "Angular 2 Google api module",
-  "main": "components.js",
-  "typings": "lib/index",
+  "main": "./lib/index.js",
+  "typings": "./lib/index",
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1"
   },
@@ -30,16 +30,14 @@
     "url": "https://github.com/rubenCodeforges/angular2-google-api/issues"
   },
   "homepage": "https://github.com/rubenCodeforges/angular2-google-api#readme",
-  "devDependencies": {
-    "typescript": "^2.2.2",
+  "dependencies": {
     "@types/gapi": "0.0.31",
     "@types/gapi.auth2": "0.0.35"
   },
-  "dependencies": {
-    "@angular/common": "^4.0.0",
-    "@angular/compiler": "^4.0.0",
-    "@angular/core": "^4.0.0",
-    "@angular/http": "^4.0.0",
-    "rxjs": "^5.3.0"
+  "devDependencies": {
+    "@angular/core": "^4.1.1",
+    "rxjs": "^5.3.1",
+    "typescript": "^2.2.2",
+    "zone.js": "^0.8.10"
   }
-}
+}
diff --git a/src/GoogleApiModule.ts b/src/GoogleApiModule.ts
@@ -10,13 +10,9 @@ export class GoogleApiModule {
         return {
             ngModule: GoogleApiModule,
             providers: [
-                GoogleApiService,
                 {
                     provide: GoogleApiService,
-                    useFactory: GoogleApiService.factory,
-                    deps: [
-                        apiConfig
-                    ]
+                    useFactory: () => GoogleApiService.factory(apiConfig),
                 },
                 {
                     provide: GoogleAuthService,

diff --git a/src/GoogleApiService.ts b/src/GoogleApiService.ts
@@ -1,19 +1,19 @@
 import {Observable} from "rxjs";
 import {Injectable} from "@angular/core";
-import {GoogleApiConfig} from "./config/GoogleApiConfig";
+import {GoogleApiConfig, GapiInitConfigs} from "./config/GoogleApiConfig";
 
 @Injectable()
 export class GoogleApiService {
     private readonly gapiUrl: string = 'https://apis.google.com/js/platform.js';
     private isLoaded: boolean = false;
     private config: GoogleApiConfig;
 
-    public static factory(apiConfig: GoogleApiConfig) {
-        return new GoogleApiService(apiConfig);
+    public static factory(configs: GapiInitConfigs) {
+        return new GoogleApiService(configs);
     }
 
-    constructor(config: GoogleApiConfig) {
-        this.config = config;
+    constructor(config: GapiInitConfigs) {
+        this.config = new GoogleApiConfig(config);
         this.loadGapi();
     }
 
@@ -25,8 +25,12 @@ export class GoogleApiService {
         this.loadGapi().subscribe(callback);
     }
 
+    public getConfig(): GoogleApiConfig {
+        return this.config;
+    }
+
     private loadGapi(): Observable<void> {
-        return Observable.create((observer) => {
+        return Observable.create((observer: any) => {
             let node = document.createElement('script');
             node.src = this.gapiUrl;
             node.type = 'text/javascript';
@@ -39,4 +43,4 @@ export class GoogleApiService {
             };
         });
     }
-}
+}