Add features quantity in workspace list page #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## workspace-pr-integr #309 +/- ##
=======================================================
- Coverage 67.04% 66.94% -0.10%
=======================================================
Files 3344 2603 -741
Lines 65011 49237 -15774
Branches 10496 8895 -1601
=======================================================
- Hits 43588 32964 -10624
+ Misses 18845 14105 -4740
+ Partials 2578 2168 -410
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
SuZhou-Joe
reviewed
Mar 27, 2024
| featuresConfig: string[], | ||
| applications: PublicAppInfo[] | ||
| ) => { | ||
| const visibleApplications = applications.filter( |
There was a problem hiding this comment.
Do we need to keep the filter logic consistent above these two cases?
There was a problem hiding this comment.
I refer to this logic, but i thought we may not need to filter management here because feature config returned contain management category
| export function useApplications(application: ApplicationStart) { | ||
| const applications = useObservable(application.applications$); | ||
| export function useApplications(application?: ApplicationStart) { | ||
| const applications = useObservable(application?.applications$ ?? of(new Map()), new Map()); | ||
| return useMemo(() => { | ||
| const apps: PublicAppInfo[] = []; | ||
| applications?.forEach((app) => { |
There was a problem hiding this comment.
Suggested change
| applications?.forEach((app) => { | |
| applications.forEach((app) => { |
Hailong-am
approved these changes
Mar 27, 2024
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add features quantity in workspace list page
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integration