feat: move all saved objects to target workspace #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 106d77d.
…Dashboards into workspace-duplicate # Conflicts: # src/core/server/saved_objects/service/lib/repository.ts # src/plugins/workspace/public/components/delete_workspace_modal/delete_workspace_modal.tsx # src/plugins/workspace/server/routes/index.ts
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## workspace #292 +/- ##
=============================================
- Coverage 59.07% 55.70% -3.38%
=============================================
Files 3026 2261 -765
Lines 58158 42443 -15715
Branches 9118 7540 -1578
=============================================
- Hits 34357 23642 -10715
+ Misses 21878 17361 -4517
+ Partials 1923 1440 -483
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yubonluo
changed the title
yubonluo
changed the title
|
@yubonluo As we won't use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the button is clicked, the target workspace id will be added to the workspaces field, while retaining the current workspace id.
When I moved 2000 objects, the average response time was about 1000 ms.
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integration