fine-tuning workspace menu styles #222
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yulong Ruan <[email protected]>
yuye-aws
reviewed
Oct 11, 2023
| title={ | ||
| <h3 | ||
| style={{ | ||
| width: '202px', |
There was a problem hiding this comment.
Is is okay to use hardcode width?
There was a problem hiding this comment.
You're right, I cleanup the custom styles.
Codecov Report
@@ Coverage Diff @@
## workspace #222 +/- ##
=============================================
- Coverage 66.20% 66.16% -0.05%
=============================================
Files 3419 2709 -710
Lines 65753 51015 -14738
Branches 10590 9207 -1383
=============================================
- Hits 43535 33756 -9779
+ Misses 19574 14972 -4602
+ Partials 2644 2287 -357
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 786 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wanglam
approved these changes
Oct 11, 2023
raintygao
approved these changes
Oct 11, 2023
+ remove unnecessary styles Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
|
It seems display incorrectly when workspace is off |
Nice catch! I will fix this, thanks |
Signed-off-by: Yulong Ruan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fine-tuning workspace menu styles
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr