forked from opensearch-project/OpenSearch-Dashboards
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace savedObjectRepository with savedObjectClient #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me validation Signed-off-by: Hailong Cui <[email protected]>
Codecov Report
@@ Coverage Diff @@
## workspace #156 +/- ##
==============================================
- Coverage 60.68% 34.75% -25.93%
==============================================
Files 2898 1922 -976
Lines 56631 38148 -18483
Branches 9077 5464 -3613
==============================================
- Hits 34364 13257 -21107
- Misses 20244 24287 +4043
+ Partials 2023 604 -1419
Flags with carried forward coverage won't be shown. Click here to find out more. see 1560 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ruanyl
approved these changes
Sep 14, 2023
wanglam
approved these changes
Sep 14, 2023
opensearch-workspace-development bot
pushed a commit
that referenced
this pull request
Sep 14, 2023
…me validation (#156) Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit f350eb3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am
pushed a commit
that referenced
this pull request
Sep 15, 2023
…me validation (#156) (#160) (cherry picked from commit f350eb3) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Sep 15, 2023
…me validation (#156) Signed-off-by: Hailong Cui <[email protected]>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 16, 2023
…me validation (#156) Signed-off-by: Hailong Cui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace
savedObjectRepository
withsavedObjectClient
for workspace name unique checkIssues Resolved
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr