forked from opensearch-project/OpenSearch-Dashboards
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace] Add ACL related functions for workspace #146
Merged
gaobinlong
merged 2 commits into
ruanyl:workspace-pr-integr-2.9
from
gaobinlong:workspace-pr-integr-2.9
Sep 14, 2023
Merged
[Workspace] Add ACL related functions for workspace #146
gaobinlong
merged 2 commits into
ruanyl:workspace-pr-integr-2.9
from
gaobinlong:workspace-pr-integr-2.9
Sep 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gaobinlong <[email protected]>
Codecov Report
@@ Coverage Diff @@
## workspace-pr-integr-2.9 #146 +/- ##
===========================================================
- Coverage 66.19% 66.19% -0.01%
===========================================================
Files 3317 3318 +1
Lines 63894 63976 +82
Branches 9970 9995 +25
===========================================================
+ Hits 42297 42351 +54
- Misses 19156 19164 +8
- Partials 2441 2461 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wanglam
reviewed
Sep 13, 2023
Signed-off-by: gaobinlong <[email protected]>
wanglam
approved these changes
Sep 13, 2023
raintygao
approved these changes
Sep 14, 2023
ruanyl
pushed a commit
that referenced
this pull request
Sep 15, 2023
* [Workspace] Add acl related functions for workspace Signed-off-by: gaobinlong <[email protected]> * Minor change Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]>
wanglam
pushed a commit
that referenced
this pull request
Feb 26, 2024
* [Workspace] Add acl related functions for workspace Signed-off-by: gaobinlong <[email protected]> * Minor change Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]>
gaobinlong
added a commit
that referenced
this pull request
Mar 8, 2024
…) (#287) * [Workspace] Add ACL related functions for workspace (#146) * [Workspace] Add acl related functions for workspace * Minor change --------- * Modify changelog * Add more unit test cases * Modify test case * Some minor change * Add more test cases * Optimize some code and the comments of the functions * Add more comments for some basic functions * Export more interfaces * consume permissions in repository * feat: consume permissions in serializer * Add unit tests for consuming permissions in repository * Remove double exclamation * Rename some variables * Remove duplicated semicolon * Add permissions field to the mapping only if the permission control is enabled * Fix test failure * Add feature flag config to the yml file * Make the comment of feature flag more clear * Make comment more clear * Remove management permission type * Fix test failure --------- Signed-off-by: gaobinlong <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: Josh Romero <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
added a commit
that referenced
this pull request
Mar 11, 2024
* [Workspace][Feature] Add ACL related functions (opensearch-project#5084) * [Workspace] Add ACL related functions for workspace (#146) * [Workspace] Add acl related functions for workspace Signed-off-by: gaobinlong <[email protected]> * Minor change Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> * Modify changelog Signed-off-by: gaobinlong <[email protected]> * Add more unit test cases Signed-off-by: gaobinlong <[email protected]> * Modify test case Signed-off-by: gaobinlong <[email protected]> * Some minor change Signed-off-by: gaobinlong <[email protected]> * Add more test cases Signed-off-by: gaobinlong <[email protected]> * Optimize some code and the comments of the functions Signed-off-by: gaobinlong <[email protected]> * Add more comments for some basic functions Signed-off-by: gaobinlong <[email protected]> * Export more interfaces Signed-off-by: gaobinlong <[email protected]> * consume permissions in repository Signed-off-by: SuZhou-Joe <[email protected]> * feat: consume permissions in serializer Signed-off-by: SuZhou-Joe <[email protected]> * Add unit tests for consuming permissions in repository Signed-off-by: gaobinlong <[email protected]> * Remove double exclamation Signed-off-by: gaobinlong <[email protected]> * Rename some variables Signed-off-by: gaobinlong <[email protected]> * Remove duplicated semicolon Signed-off-by: gaobinlong <[email protected]> * Add permissions field to the mapping only if the permission control is enabled Signed-off-by: gaobinlong <[email protected]> * Fix test failure Signed-off-by: gaobinlong <[email protected]> * Add feature flag config to the yml file Signed-off-by: gaobinlong <[email protected]> * Make the comment of feature flag more clear Signed-off-by: gaobinlong <[email protected]> * Make comment more clear Signed-off-by: gaobinlong <[email protected]> * Remove management permission type Signed-off-by: gaobinlong <[email protected]> * Fix test failure Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: Josh Romero <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> * Remove duplicated attribute Signed-off-by: gaobinlong <[email protected]> * Enable acl in integration tests for workspace client wrapper Signed-off-by: gaobinlong <[email protected]> * Format the code Signed-off-by: gaobinlong <[email protected]> * Modify feature flag Signed-off-by: gaobinlong <[email protected]> * Modify feature flag to false Signed-off-by: gaobinlong <[email protected]> * Modify feature flag to true Signed-off-by: gaobinlong <[email protected]> * Enhance the test case Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: Josh Romero <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Mar 11, 2024
* [Workspace] Add acl related functions for workspace Signed-off-by: gaobinlong <[email protected]> * Minor change Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Mar 18, 2024
* [Workspace] Add acl related functions for workspace Signed-off-by: gaobinlong <[email protected]> * Minor change Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]>
SuZhou-Joe
added a commit
that referenced
this pull request
Mar 18, 2024
…) (#287) * [Workspace] Add ACL related functions for workspace (#146) * [Workspace] Add acl related functions for workspace * Minor change --------- * Modify changelog * Add more unit test cases * Modify test case * Some minor change * Add more test cases * Optimize some code and the comments of the functions * Add more comments for some basic functions * Export more interfaces * consume permissions in repository * feat: consume permissions in serializer * Add unit tests for consuming permissions in repository * Remove double exclamation * Rename some variables * Remove duplicated semicolon * Add permissions field to the mapping only if the permission control is enabled * Fix test failure * Add feature flag config to the yml file * Make the comment of feature flag more clear * Make comment more clear * Remove management permission type * Fix test failure --------- Signed-off-by: gaobinlong <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: Josh Romero <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]>
ruanyl
pushed a commit
that referenced
this pull request
Apr 16, 2024
…) (opensearch-project#6405) * [Workspace] Add ACL related functions for workspace (#146) * consume permissions in repository * feat: consume permissions in serializer * Add unit tests for consuming permissions in repository * Remove double exclamation * Rename some variables * Remove duplicated semicolon * Add permissions field to the mapping only if the permission control is enabled * Fix test failure * Add feature flag config to the yml file * Make the comment of feature flag more clear * Make comment more clear * Remove management permission type * Fix test failure --------- (cherry picked from commit 54c36fe) Signed-off-by: gaobinlong <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Josh Romero <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main change of this PR are:
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr