Retire dashboards management (#138)

* feat: retire management section Signed-off-by: tygao <[email protected]> * fix: fix path Signed-off-by: tygao <[email protected]> * chore: remove unused Signed-off-by: tygao <[email protected]> * fix: update path Signed-off-by: tygao <[email protected]> * fix: update path Signed-off-by: tygao <[email protected]> * chore: remove unused after rebase Signed-off-by: tygao <[email protected]> * fix: remove extra import Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]>
ruanyl · Sep 15, 2023 · e5039e2 · e5039e2
1 parent 461cffb
commit e5039e2
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 27 deletions.
diff --git a/src/plugins/advanced_settings/public/plugin.ts b/src/plugins/advanced_settings/public/plugin.ts
@@ -43,7 +43,7 @@ const title = i18n.translate('advancedSettings.advancedSettingsLabel', {
 
 export class AdvancedSettingsPlugin
   implements Plugin<AdvancedSettingsSetup, AdvancedSettingsStart, AdvancedSettingsPluginSetup> {
-  public setup(core: CoreSetup, { management, home }: AdvancedSettingsPluginSetup) {
+  public setup(core: CoreSetup, { home }: AdvancedSettingsPluginSetup) {
     core.application.register({
       id: 'settings',
       title,

diff --git a/...earch_dashboards_react/public/overview_page/overview_page_header/overview_page_header.tsx b/...earch_dashboards_react/public/overview_page/overview_page_header/overview_page_header.tsx
@@ -136,7 +136,7 @@ export const OverviewPageHeader: FC<Props> = ({
                         className="osdOverviewPageHeader__actionButton"
                         flush="both"
                         iconType="gear"
-                        href={addBasePath('/app/management')}
+                        href={addBasePath('/app/settings')}
                       >
                         {i18n.translate(
                           'opensearch-dashboards-react.osdOverviewPageHeader.stackManagementButtonLabel',

diff --git a/src/plugins/saved_objects_management/public/plugin.ts b/src/plugins/saved_objects_management/public/plugin.ts
@@ -58,7 +58,6 @@ import { bootstrap } from './ui_actions_bootstrap';
 import { DEFAULT_APP_CATEGORIES } from '../../../core/public';
 import {
   MANAGE_LIBRARY_TITLE_WORDINGS,
-  SAVED_OBJECT_MANAGEMENT_TITLE_WORDINGS,
   SAVED_QUERIES_WORDINGS,
   SAVED_SEARCHES_WORDINGS,
 } from './constants';
@@ -68,7 +67,6 @@ export interface SavedObjectsManagementPluginSetup {
   columns: SavedObjectsManagementColumnServiceSetup;
   namespaces: SavedObjectsManagementNamespaceServiceSetup;
   serviceRegistry: ISavedObjectsManagementServiceRegistry;
-  registerLibrarySubApp: () => void;
 }
 
 export interface SavedObjectsManagementPluginStart {
@@ -170,7 +168,7 @@ export class SavedObjectsManagementPlugin
 
   public setup(
     core: CoreSetup<StartDependencies, SavedObjectsManagementPluginStart>,
-    { home, management, uiActions }: SetupDependencies
+    { home, uiActions }: SetupDependencies
   ): SavedObjectsManagementPluginSetup {
     const actionSetup = this.actionService.setup();
     const columnSetup = this.columnService.setup();
@@ -193,24 +191,6 @@ export class SavedObjectsManagementPlugin
       });
     }
 
-    const opensearchDashboardsSection = management.sections.section.opensearchDashboards;
-    opensearchDashboardsSection.registerApp({
-      id: 'objects',
-      title: i18n.translate('savedObjectsManagement.managementSectionLabel', {
-        defaultMessage: 'Saved objects',
-      }),
-      order: 1,
-      mount: async (mountParams) => {
-        const { mountManagementSection } = await import('./management_section');
-        return mountManagementSection({
-          core,
-          serviceRegistry: this.serviceRegistry,
-          mountParams,
-          title: SAVED_OBJECT_MANAGEMENT_TITLE_WORDINGS,
-        });
-      },
-    });
-
     // sets up the context mappings and registers any triggers/actions for the plugin
     bootstrap(uiActions);
 
@@ -224,7 +204,6 @@ export class SavedObjectsManagementPlugin
       columns: columnSetup,
       namespaces: namespaceSetup,
       serviceRegistry: this.serviceRegistry,
-      registerLibrarySubApp: () => {},
     };
   }
 

diff --git a/src/plugins/workspace/public/plugin.ts b/src/plugins/workspace/public/plugin.ts
@@ -93,9 +93,6 @@ export class WorkspacePlugin implements Plugin<{}, {}, WorkspacePluginSetupDeps>
      */
     savedObjectsManagement?.columns.register(getWorkspaceColumn(core));
 
-    // register apps for library object management
-    savedObjectsManagement?.registerLibrarySubApp();
-
     type WorkspaceAppType = (params: AppMountParameters, services: Services) => () => void;
     const mountWorkspaceApp = async (params: AppMountParameters, renderApp: WorkspaceAppType) => {
       const [coreStart] = await core.getStartServices();