show error toast when getting error from text to vega execution

Signed-off-by: Yulong Ruan <[email protected]>
ruanyl · Jun 4, 2024 · 7a829b8 · 7a829b8
1 parent 0edeade
commit 7a829b8
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/plugins/vis_type_vega/public/components/vega_vis_editor.tsx b/src/plugins/vis_type_vega/public/components/vega_vis_editor.tsx
@@ -97,7 +97,15 @@ function VegaVisEditor({ stateParams, setValue }: VisOptionsProps<VisParams>) {
     const text2vega = getText2Vega();
     const subscription = text2vega.getResult$().subscribe((result) => {
       if (result) {
-        setValue('spec', JSON.stringify(result, null, 4));
+        if (result.error) {
+          getNotifications().toasts.addError(result.error, {
+            title: i18n.translate('visTypeVega.editor.llmError', {
+              defaultMessage: 'Error while executing text to vega',
+            }),
+          });
+        } else {
+          setValue('spec', JSON.stringify(result, null, 4));
+        }
       }
     });
 

diff --git a/src/plugins/vis_type_vega/public/text_to_vega.ts b/src/plugins/vis_type_vega/public/text_to_vega.ts
@@ -30,7 +30,7 @@ Just reply with the json based Vega-Lite object, do not include any other conten
 
 export class Text2Vega {
   input$ = new BehaviorSubject({ input: '' });
-  result$: Observable<string | Error>;
+  result$: Observable<Record<string, any> | { error: any }>;
   status$ = new BehaviorSubject<'RUNNING' | 'STOPPED'>('STOPPED');
   http: HttpSetup;