Tolerate fine-grained GitHub tokens #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Michael Barton reported with #10, switching from _classic_ GitHub tokens to fine-grained tokens crashes Prout, because the play-git-hub expected HTTP response headers to detail OAuth scopes (`X-OAuth-Scopes` & `X-Accepted-OAuth-Scopes`) - but those aren't returned in GitHub API responses for fine-grained tokens. The change in this commit is a small alteration from Michael's PR - rather than returning a `RequestScopes` object containing empty Sets of scopes, it just makes the `RequestScopes` field optional within `ResponseMeta`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Michael Barton reported with #10, switching from classic GitHub tokens to fine-grained tokens crashes Prout, because the
play-git-hublibrary expected HTTP response headers to detail OAuth scopes (X-OAuth-Scopes&X-Accepted-OAuth-Scopes) - but those aren't returned in GitHub API responses for fine-grained tokens.The change in this commit is a small alteration from Michael's PR - rather than returning a
RequestScopesobject containing emptySets of scopes, it just makes theRequestScopesfield optional withinResponseMeta.