Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWN-194614 #88

Merged
merged 4 commits into from
Apr 4, 2023
Merged

AWN-194614 #88

merged 4 commits into from
Apr 4, 2023

Conversation

laiba-zaman
Copy link

expected guide for plugin 'google.serviceAccountTokenCreator' at en/google/iam/service-account-token-creator: provider='google', category='IAM', title='Service Account Token Creator'

@laiba-zaman laiba-zaman requested a review from areed42 March 28, 2023 14:49
2. Select a project, folder, or organization (in this case the GCP project).

The Google Cloud console lists all the principals who have been granted roles on your project, folder, or organization. This list includes principals who have inherited roles on the resource from parent resources. For more information about policy inheritance, see [Policy inheritance and the resource hierarchy](https://cloud.google.com/iam/docs/policies#inheritance).
Check to see if any have the Service Account Access Role.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this another step. This way there are 4 in total.

laiba-zaman and others added 2 commits April 4, 2023 14:09
I made some changes based on documentation I found elsewhere. Also corrected the link to the document referenced in the plugin.
Copy link

@areed42 areed42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to merge

@laiba-zaman laiba-zaman merged commit c999e4d into master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants