AWN-194574 #82
Merged
AWN-194574 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
areed42
approved these changes
Apr 4, 2023
en/google/sql/sql-cmk-encryption.md
Outdated
|
|
||
| 4. Click on the Pencil icon associated with the Encryption type entry. | ||
|
|
||
| 5. Set or remove the default Cloud KMS key for the bucket. |
There was a problem hiding this comment.
Given that the recommendations are to use the default encryption keys, this verbiage needs changed to specify this. I'd edit the line to reflect that and then remove or adjust options a / b accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expected guide for plugin 'google.sqlCMKEncryption' at en/google/sql/sql-cmk-encryption: provider='google', category='SQL', title='SQL CMK Encryption'