Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request tabs Permission Only When Needed #55

Closed
rthaut opened this issue Feb 12, 2019 · 0 comments · Fixed by #59
Closed

Request tabs Permission Only When Needed #55

rthaut opened this issue Feb 12, 2019 · 0 comments · Fixed by #59
Assignees
Milestone

Comments

@rthaut
Copy link
Owner

rthaut commented Feb 12, 2019

This is related to #50

Since the tabs permission actually provides a lot of power, and since the wording for both Firefox and Chrome (but mostly Chrome) is very misleading, it would probably be better to only request the tabs permission when the "Close Original Window/Tab" setting is enabled.

Furthermore, since that setting is disabled by default, its possible that many users won't even enable it, so always requiring the tabs permission then becomes careless.

Per the documentation:

requests may only be made in the handler for a user action (for example, a click handler)

With that in mind, the most logical way of handling this is to request the tabs permission when the user toggles the "Close Original Window/Tab" setting to "on," and it would also be logical to remove the tabs permission whenever that setting is toggled back to "off."

@rthaut rthaut added this to the 3.1.0 milestone Feb 12, 2019
@rthaut rthaut self-assigned this Feb 12, 2019
@rthaut rthaut mentioned this issue Feb 18, 2019
rthaut added a commit that referenced this issue Feb 21, 2019
## New Features

- Tabbed Layout for Options Page (closes #58)
- Auto Save Options (closes #54)

## Updates

- Request `tabs` Permission Only When Needed (closes #55)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant