Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Open Popout Player Window Maximized #354

Closed
rthaut opened this issue Aug 14, 2021 · 0 comments · Fixed by #361
Closed

Feature Request: Open Popout Player Window Maximized #354

rthaut opened this issue Aug 14, 2021 · 0 comments · Fixed by #361

Comments

@rthaut
Copy link
Owner

rthaut commented Aug 14, 2021

Users have requested a way to open the Popout Player window in maximized state initially.

This would most likely be done as a new value for the Size option, since there's not much reason to set a size AND open the window maximized (plus it can't be done in a single windows.create()/windows.update() operation).

However, this will also require an additional option to choose whether the window type is a "popup" or a "standard" window. It seems "popup" windows have the maximize button disabled (at least in some browser/OS combinations), which prevents the Popout Player window from easily being un-maximized. Using a "standard" window allows the maximize button to work normally, but it also renders the full window UI (address bar, bookmark bar, etc.)

For the actual implementation, the window will need to be opened normally first, then positioned, and then finally maximized. This is because:

  1. Creating a window with "maximized" state does not allow setting a position, which means we can't open it on (technically move it to) a secondary monitor.
  2. Window positioning is currently handled via windows.update() AFTER creating the window. I think this was due to a Firefox bug/quirk where supplying position values to windows.create() didn't work.
rthaut added a commit that referenced this issue Sep 23, 2021
* add new option and corresponding logic to maximize popout player window; closes #354
* tweak verbiage of maximized size mode option description
* update Options documentation page and screenshots
@rthaut rthaut mentioned this issue Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant