Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow ssl.SSLContext type in the verify= argument of dns.query.https() #1173

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tykling
Copy link
Contributor

@tykling tykling commented Jan 12, 2025

Proposed fix for #1172

Originally this PR also changed the type annotation for dns.query.dot() and dns.query.quic() but since it wasn't needed and also wasn't trivial I removed it again.

@tykling tykling changed the title allow ssl.SSLContext type in the verify= argument of dns.query.(https|quic|tls) allow ssl.SSLContext type in the verify= argument of dns.query.https() Jan 12, 2025
@bwelling
Copy link
Collaborator

It would definitely be more convenient if an ssl.SSLContext could be passed into the other methods as well, but it's probably out of scope for this PR.

If dns.query.https is updated, though, dns.asyncquery.https should also be updated.

@tykling
Copy link
Contributor Author

tykling commented Feb 16, 2025

I did originally change this for the other protocols as well until I got to dns.query.tls() which does it's own thing making an sslcontext and I didn't know what to do about that

@tykling
Copy link
Contributor Author

tykling commented Feb 16, 2025

I pushed the same change for dns.asyncquery.https() :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants