Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output of git status -z should not be stripped #75

Closed
ohumbel opened this issue Nov 2, 2015 · 4 comments
Closed

output of git status -z should not be stripped #75

ohumbel opened this issue Nov 2, 2015 · 4 comments
Assignees
Labels

Comments

@ohumbel
Copy link
Member

ohumbel commented Nov 2, 2015

Since the whole purpose of git status -z is to have a formatted output, it is wrong to strip these lines.
Currently we miss deletions of .jazzignore, because the deletion mark starts at position 2 (blanks indicated as _ below):

_D_theFolder/.jazzignore

@ohumbel ohumbel added the bug label Nov 2, 2015
@ohumbel ohumbel self-assigned this Nov 2, 2015
@WtfJoke
Copy link
Member

WtfJoke commented Nov 2, 2015

Do you mean the stripping here shell.py#L29?

And to the issue itself: Ouch, that hurts 😦

I suggest an optional parameter for stripping on off? Or do you have a better idea in mind?

@ohumbel
Copy link
Member Author

ohumbel commented Nov 2, 2015

Yes, exactly that stripping (plus an additional one in the parsing of git status -z).
It did not yet hurt too much. I stumbled over it while trying to fix the many "invalid date" errors seen in the travis log.
And I thought of an additional parameter as well. I do not know which logic is depending on the stripping. Maybe only of the exclusion of blank lines?

ohumbel added a commit to ohumbel/rtc2git that referenced this issue Nov 3, 2015
Enables recognition of deletion lines like
[ D aFolder/.jazzignore]
Fixes rtcTo#75.
@ohumbel
Copy link
Member Author

ohumbel commented Nov 6, 2015

@WtfJoke any chance to have a look at my pull request?

@WtfJoke
Copy link
Member

WtfJoke commented Nov 6, 2015

Yup, sorry. Somehow overlooked it. Thanks for fixing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants