Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH : #1912 Video thumbnail not visible on Activity page #1915

Merged
merged 2 commits into from
May 19, 2022
Merged

GH : #1912 Video thumbnail not visible on Activity page #1915

merged 2 commits into from
May 19, 2022

Conversation

Mukulsingh27
Copy link
Member

  1. Video thumbnail not visible on Activity page #1912
  • Add the default video thumbnail for the activity page.

@Mukulsingh27 Mukulsingh27 requested a review from Pradeep1308 May 16, 2022 12:48
@pavanpatil1
Copy link
Contributor

Hi @Mukulsingh27, I checked the PR. Now the thumbnail for the video is visible on the activity page. But with the rtMedia custom thumbnail addon, it is not changing the thumbnail of the video file.

Expected Result: It should change the video thumbnail as per the custom thumbnail added by the user and if no thumbnail is added then only the default thumbnail should be visible.

Untitled_.May.17.2022.2_20.PM.mp4

@pavanpatil1
Copy link
Contributor

Verified the PR again. The fix is working fine now. You can merge the PR @Mukulsingh27 once the code review is done.

Untitled_.May.18.2022.5_10.PM.mp4

@Mukulsingh27 Mukulsingh27 merged commit c62a258 into pre-release May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pradeep1308 Pradeep1308 Pradeep1308 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mukulsingh27 @pavanpatil1 @Pradeep1308