Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with ros2 branch #195

Merged
merged 10 commits into from
Dec 19, 2023
Merged

Sync with ros2 branch #195

merged 10 commits into from
Dec 19, 2023

Conversation

Kuwamai
Copy link
Contributor

@Kuwamai Kuwamai commented Dec 18, 2023

What does this implement/fix?

ros2ブランチの更新を反映させるPRです

Does this close any currently open issues?

しません

How has this been tested?

ros2ブランチでテスト済みのためテスト不要です

Any other comments?

ないです

Checklists

Kuwamai and others added 9 commits February 20, 2023 09:54
* 点群を0.5mの距離でフィルタリング

* Voxel gridでダウンサンプリング

* 点群の座標変換

* 点群の座標変換修正

* 点群の取得範囲変更

* KdTreeによるクラスタリング

* 認識した物体位置をtfで配信

* スタイル修正

* ファイル名変更

* point_cloud_detectionをサンプル実行用launchに追加

* 不要な変数を削除

* Update README

* プレース後の物体を再度把持してしまうためプレース位置修正

* 認識後の点群をRvizに表示

* 平面検出処理追加

* コメント修正

* READMEに動画URL追加

* tfの表示時間短縮

* タイムスタンプを一致させるためheaderをコピー

* 点群の重心位置を物体位置として配信

* tfの取得時間の範囲を変更

* 物体位置の高さ制限を追加

* 平面検出をコメントアウト

* newをmake_sharedに置き換え

* 点群処理を複数の関数に分割

* Copyright表記修正

Co-authored-by: Shota Aoki <[email protected]>

* Update README

* 変数の型修正

Co-authored-by: Shota Aoki <[email protected]>

* 変数の型修正

Co-authored-by: Shota Aoki <[email protected]>

* 変数名修正

Co-authored-by: Shota Aoki <[email protected]>

* 点群取得範囲修正

Co-authored-by: Shota Aoki <[email protected]>

* 平面検出の判定条件修正

Co-authored-by: Shota Aoki <[email protected]>

* for文を範囲for文に変更

Co-authored-by: Shota Aoki <[email protected]>

* for文を範囲for文に変更

Co-authored-by: Shota Aoki <[email protected]>

* 認識範囲に点群がない場合INFOを出力

---------

Co-authored-by: Shota Aoki <[email protected]>
* 色認識追加

* 二値化画像を配信

* 不要な処理を削除

* RVizに二値化画像を表示

* 距離のオフセット追加

* 変数名変更

* カーネルを変更

* 不要な空行を削除

* 画像取得時のheaderをtfに使用

* コメント、変数名修正

* Update README

* コメント修正

* 変数名変更
Remove gz ros2 controll installation
* goal_tolerance調整

* グリッパ角調整
@Kuwamai Kuwamai closed this Dec 18, 2023
@Kuwamai Kuwamai reopened this Dec 18, 2023
@Kuwamai Kuwamai changed the title Ros2 Sync with ros2 branch Dec 18, 2023
@Kuwamai Kuwamai requested a review from ShotaAk December 18, 2023 09:47
@Kuwamai Kuwamai self-assigned this Dec 18, 2023
@Kuwamai Kuwamai added the Type: Feature New Feature label Dec 18, 2023
@Kuwamai Kuwamai marked this pull request as ready for review December 18, 2023 09:48
Copy link
Contributor

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShotaAk ShotaAk merged commit 52fca05 into humble-devel Dec 19, 2023
1 check passed
@ShotaAk ShotaAk deleted the ros2 branch December 19, 2023 01:19
@Kuwamai Kuwamai restored the ros2 branch December 19, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants