Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS support #17

Merged
merged 9 commits into from
Apr 18, 2024
Merged

Add macOS support #17

merged 9 commits into from
Apr 18, 2024

Conversation

guruor
Copy link
Contributor

@guruor guruor commented Apr 15, 2024

Changes needed for #16 building on macos.

justfile Outdated Show resolved Hide resolved
@rszyma
Copy link
Owner

rszyma commented Apr 15, 2024

  1. Does macos require any dependencies? If yes please add them to readme.

  2. It would be nice to add macos to CI (see https://github.com/rszyma/kanata-tray/tree/main/.github/workflows)

@guruor
Copy link
Contributor Author

guruor commented Apr 16, 2024

Does macos require any dependencies? If yes please add them to readme.

I did not require any dependencies so can't commit if any was pre-requisite, will have to try it on a fresh system.

It would be nice to add macos to CI (see https://github.com/rszyma/kanata-tray/tree/main/.github/workflows)

Let me try adding the workflow, it will help us determine if any dependency is required.

@rszyma
Copy link
Owner

rszyma commented Apr 16, 2024

Let me try adding the workflow, it will help us determine if any dependency is required.

There won't be any build time dependency, I rather thought about runtime dependency (look at linux dependencies in readme, these are runtime ones).

Using ldd might help https://stackoverflow.com/a/6589958/9611188. Though there's no pressure to find out the required libraries now, they can be added later to readme.

Copy link
Owner

@rszyma rszyma Apr 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it possible to cross-compile for macos from ubuntu like it's done for windows? Otherwise there would be a lot of duplication after applying your proposed changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually never actually built cross-platform builds before so don't have much idea about it. Though I tried running the github actions locally to build it on same ubuntu runner but faced issues related to clang and so I tried the macos runner and it was successful so did this change.

justfile Outdated Show resolved Hide resolved
@rszyma rszyma merged commit 000b8aa into rszyma:main Apr 18, 2024
3 checks passed
@rszyma rszyma changed the title Added build command for mac Add macOS support Apr 18, 2024
@rszyma
Copy link
Owner

rszyma commented Apr 18, 2024

I wanted to see the what's the error with cross-compiling https://github.com/rszyma/kanata-tray/actions/runs/8730443667/job/23954275895

Let's just use your solution.

Thanks for the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants