-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add macOS support #17
Conversation
|
I did not require any dependencies so can't commit if any was pre-requisite, will have to try it on a fresh system.
Let me try adding the workflow, it will help us determine if any dependency is required. |
There won't be any build time dependency, I rather thought about runtime dependency (look at linux dependencies in readme, these are runtime ones). Using ldd might help https://stackoverflow.com/a/6589958/9611188. Though there's no pressure to find out the required libraries now, they can be added later to readme. |
.github/workflows/release.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it possible to cross-compile for macos from ubuntu like it's done for windows? Otherwise there would be a lot of duplication after applying your proposed changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually never actually built cross-platform builds before so don't have much idea about it. Though I tried running the github actions locally to build it on same ubuntu runner but faced issues related to clang and so I tried the macos runner and it was successful so did this change.
I wanted to see the what's the error with cross-compiling https://github.com/rszyma/kanata-tray/actions/runs/8730443667/job/23954275895 Let's just use your solution. Thanks for the PR :) |
Changes needed for #16 building on macos.