Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing env improvements - add test environments and bump versions #481

Merged
merged 10 commits into from
Jan 25, 2022

Conversation

sergioisidoro
Copy link
Member

@sergioisidoro sergioisidoro commented Jan 24, 2022

Some housekeeping:

  • Bumps patch and minor versions on test matrix
  • Adds Rails 7 to test matrix
  • Adds Ruby 3.0 and 3.1 ( Excluding older Rails versions from tests in Ruby 3.x )
  • Adds some annotations about EOLs of testing environments
  • Adds a Docker and Docker compose to easily debug in any environment (ARM64 makes it sometimes tricky to use older Ruby versions)
  • Removes truffleruby-head from the test matrix as it was a bit discussed on the PRs Greg authored. -- eg Fix truffleruby workflow #479 (comment)

@sergioisidoro
Copy link
Member Author

            LoadError:
              cannot load such file -- net/smtp

Potentially an upstream problem - https://stackoverflow.com/a/70500221/2943164

@sergioisidoro
Copy link
Member Author

NameError:
  uninitialized constant ActiveSupport::XmlMini::IsolatedExecutionState

Some more upstream issues rails/rails#43851

@sergioisidoro
Copy link
Member Author

sergioisidoro commented Jan 24, 2022

@BookOfGreg At least test suite is now green with Rails 7 🎉
Some significant issues upstream were fount, but have patches, but I think they are not relevant to the gem itself.

Let me know if this is enough to get this forward, and sorry for the duplicate work that you started.


case rails_version.split('.').first
when '3', '4', '5'
when '5'
Copy link
Member Author

@sergioisidoro sergioisidoro Jan 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of deprecated Rails 3 and 4 here.
But as Rails 5 is reaching its end of life I think it's quite reasonable (besides it's not tested)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes they're out of support by Rails so they're good to drop.

@wheatevo wheatevo mentioned this pull request Jan 25, 2022
Copy link
Member

@BookOfGreg BookOfGreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for repairing and adding to the test suite here.


case rails_version.split('.').first
when '3', '4', '5'
when '5'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes they're out of support by Rails so they're good to drop.

- ./test-app:/rswag/test-app
test:
<<: *base-test
command: sh -c 'bundle exec rake db:setup && bundle exec rspec'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good move for local convenience 👍

@BookOfGreg BookOfGreg merged commit b971f29 into rswag:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants