-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing env improvements - add test environments and bump versions #481
Conversation
Potentially an upstream problem - https://stackoverflow.com/a/70500221/2943164 |
Some more upstream issues rails/rails#43851 |
@BookOfGreg At least test suite is now green with Rails 7 🎉 Let me know if this is enough to get this forward, and sorry for the duplicate work that you started. |
|
||
case rails_version.split('.').first | ||
when '3', '4', '5' | ||
when '5' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kind of deprecated Rails 3 and 4 here.
But as Rails 5 is reaching its end of life I think it's quite reasonable (besides it's not tested)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes they're out of support by Rails so they're good to drop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for repairing and adding to the test suite here.
|
||
case rails_version.split('.').first | ||
when '3', '4', '5' | ||
when '5' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes they're out of support by Rails so they're good to drop.
- ./test-app:/rswag/test-app | ||
test: | ||
<<: *base-test | ||
command: sh -c 'bundle exec rake db:setup && bundle exec rspec' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good move for local convenience 👍
Some housekeeping:
truffleruby-head
from the test matrix as it was a bit discussed on the PRs Greg authored. -- eg Fix truffleruby workflow #479 (comment)