-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pandas deprecation of Exponential Moving Average function ewma #5
Comments
This will be a easy fix for all pandas versions since we will not rely on the suggestion Instead we have re-written our function ema in terms of
Exponential moving average is mathematically a special case of To emphasize this fact, we have moved our ema() function This fix shall be effective as of fecon235 v4.16.1030 |
As of pandas 0.18, pd.ewma() is DEPRECATED. Our old ema() has been commented out in lib/yi_1tools.py then new ema() has been rewritten in lib/yi_timeseries.py as a special case of holtlevel() See issue #5 for details regarding Deprecation warning, Exponential Moving Average and Holt-Winters smoothing: #5
ema() bug fix -- 2016.12.14The new dependency of ema() on holtlevel() revealed a bug which produced REMEDY: pull the latest master branch. |
Modified: yi_timeseries.py Also a fix for recently rewritten ema() since it assumes beta=0. The symptoms were bizarre exponential moving average estimates due to the growth coefficient unintentionally set always to a non-zero constant equal to y[1]-y[0], rather than zero.
SUMMARY: code for Holt-Winters filter and Exponential moving averageThey are bundled in this module: ema() is written as a special case of holtlevel() |
See discussion: #5 Include test of holt() and its workout dataframe. Include test of ema() which is a special case of Holt-Winters.
thanks :P |
2018 Addendum for ema()The fecon235 source code was refactored in https://git.io/fecon236 Here's the specific module for Holt-Winters which includes ema(): The code is also useful in finding the optimal parameter used in the And the tests give some numerical examples: ... requires at least Python 2.7 or Python 3.4. |
Description of specific issue
As of pandas 0.18 the use of its ewma() function will produce a warning which looks like:
therefore, this deprecation will adversely impact fecon235 exponential moving average
function ema in the yi_1tools module -- when pandas goes to 0.19.
Expected behavior
No warning to be raised.
Observed behavior
Computed result has no errors. The warning is given only the first time when the
exponential moving average function is used.
Strangely,
pd.ewm_mean??
produces no results, so the warning is cryptic.Why would the improvement/fix be useful to most users?
Additional helpful details for bugs
The text was updated successfully, but these errors were encountered: